Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13411 )
Change subject: hms: have tools ignore other clusters ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13411/1/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/13411/1/src/kudu/tools/tool_action_hms.cc@161 PS1, Line 161: // Note: checking the master addresses should be done separately. > Hrm.. that's a good point. WDYT about adding a --ignore_master_addrs (defau I think for the table filtering below, any table which shares a single master with this Kudu cluster should not be filtered out. Then those should be included and checked here. For tables where no-masters match, --ignore_master_addrs would be nice so that in cases where all masters don't match, users can still migrate/drop those hms entries. -- To view, visit http://gerrit.cloudera.org:8080/13411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4e2ad5835fd7fedd1e963d234b153c1df5f8766 Gerrit-Change-Number: 13411 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 23 May 2019 18:37:32 +0000 Gerrit-HasComments: Yes
