Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13411 )
Change subject: hms: have tools ignore other clusters ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13411/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/13411/2/src/kudu/tools/tool_action_hms.cc@306 PS2, Line 306: unordered_set<string> nit: I'm not sure unordered_set buys much in this context. Comparing ordered sets is O(N), when comparing unordered sets is O(N^2). -- To view, visit http://gerrit.cloudera.org:8080/13411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4e2ad5835fd7fedd1e963d234b153c1df5f8766 Gerrit-Change-Number: 13411 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 24 May 2019 20:35:02 +0000 Gerrit-HasComments: Yes
