Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13411 )
Change subject: hms: have tools ignore other clusters ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/kudu-tool-test.cc@3837 PS4, Line 3837: ASSERT_OK(AlterHmsWithReplacedParam(&hms_client, "default", "table", : HmsClient::kKuduMasterAddrsKey, > I think it's more simple to keep these checks/concerns separate. Given we h It's on another cluster, so I don't think it's a good idea to match IDs. UUIDs should be universally unique, but that scenario seems possible eg if for some reason multiple clusters have been brought up from the same physical copy. http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/tool_action_hms.cc@322 PS4, Line 322: r (hive::Table& hms_table : hms_ta > nit: Can you add a short description here of how master addrs are compared? Done -- To view, visit http://gerrit.cloudera.org:8080/13411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4e2ad5835fd7fedd1e963d234b153c1df5f8766 Gerrit-Change-Number: 13411 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Wed, 29 May 2019 23:55:33 +0000 Gerrit-HasComments: Yes
