Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13384 )
Change subject: hms: fix flakiness of master-stress-test from managed tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc@279 PS1, Line 279: if (hms_client_ && s.IsRemoteError() && : MatchPattern(s.ToString(), "*FileNotFoundException*")) { : // Check that the table was not created in Kudu. : client::sp::shared_ptr<KuduTable> table; : s = client_->OpenTable(to_create, &table); : CHECK(s.IsNotFound()) << s.ToString(); : : // Check that the table was not created in the HMS. : Slice db; : Slice table_name; : CHECK_OK(ParseHiveTableIdentifier(to_create, &db, &table_name)); : hive::Table hms_table; : Status s = hms_client_->GetTable(db.To > I'm curious whether this piece might inadvertently hide issues in other sce Done http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc@280 PS1, Line 280: MatchPattern(s.ToString(), "*FileNotFoundException*")) { : // Check that the table was not created in Kudu. : client::sp::shared_ptr<KuduTable> table; : s = client_->OpenTable(to_create, &table); : CHECK(s.IsNotFound()) << s.ToString(); : : // Check that the table was not created in the HMS. : Slice db; : Slice table_name; : CHECK_OK(ParseHiveTableIdentifier(to_create, &db, &table_name)); : hive::Table hms_table; : Status s = hms_client_->GetTable(db.To > Another this I'm curious is whether this check catches all the outcomes of If the table hasn't been rolled back, the new leader will see an AlreadyPresent error. The race you described is the cause of: https://jira.apache.org/jira/browse/KUDU-2718 The error there looks like: Bad status: Already present: Error creating table default.test_delete_table_sync on the master: an error occurred while creating table default.test_delete_table_sync in the HMS: failed to create Hive MetaStore table: TException - service has thrown: AlreadyExistsException(message=Table test_delete_table_sync already exists) -- To view, visit http://gerrit.cloudera.org:8080/13384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1233e5b133035d36f98ce08265c0273570caa454 Gerrit-Change-Number: 13384 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 23 May 2019 23:23:52 +0000 Gerrit-HasComments: Yes
