Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13384 )
Change subject: hms: fix flakiness of master-stress-test from managed tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13384/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13384/2//COMMIT_MSG@9 PS2, Line 9: managed tables opened the door > I think this can happen without the switch? Switching only means it increas This can't happen before the switch because external tables will not drop data when dropping the tables. See: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L2647 which checks if it's external here: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L2704 and based on that, it doesn't drop data: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L2682 http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc@280 PS1, Line 280: MatchPattern(s.ToString(), "*FileNotFoundException*")) { : // Check that the table was not created in Kudu. : client::sp::shared_ptr<KuduTable> table; : s = client_->OpenTable(to_create, &table); : CHECK(s.IsNotFound()) << s.ToString(); : : // Check that the table was not created in the HMS. : Slice db; : Slice table_name; : CHECK_OK(ParseHiveTableIdentifier(to_create, &db, &table_name)); : hive::Table hms_table; : Status s = hms_client_->GetTable(db.To > Have you ever saw master-stress-test failed with such error? If so, should No, just master_failover-itest. It doesn't show up here because the RPC timeout is bumped up enough (60s in this test) that the client will wait long enough for the rollback to complete before sending the second create table request. -- To view, visit http://gerrit.cloudera.org:8080/13384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1233e5b133035d36f98ce08265c0273570caa454 Gerrit-Change-Number: 13384 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 May 2019 01:03:40 +0000 Gerrit-HasComments: Yes
