Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13384 )
Change subject: hms: fix flakiness of master-stress-test from managed tables ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/13384/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13384/2//COMMIT_MSG@9 PS2, Line 9: managed tables opened the door > This can't happen before the switch because external tables will not drop d Ah, right, thanks a lot for the explanation. http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/13384/1/src/kudu/integration-tests/master-stress-test.cc@280 PS1, Line 280: // underlying Kudu table should not be created. : if (hms_client_ && s.IsRemoteError() && : MatchPattern(s.ToString(), "*FileNotFoundException*")) { : // Check that the table was not created in Kudu. : client::sp::shared_ptr<KuduTable> table; : s = client_->OpenTable(to_create, &table); : CHECK(s.IsNotFound()) << s.ToString(); : : // Check that the table was not created in the HMS. : Slice db; : Slice table_name; : CHECK_OK(ParseHiveTableIdentifier(to_c > No, just master_failover-itest. It doesn't show up here because the RPC tim Ok, sounds good. -- To view, visit http://gerrit.cloudera.org:8080/13384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1233e5b133035d36f98ce08265c0273570caa454 Gerrit-Change-Number: 13384 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 May 2019 01:16:49 +0000 Gerrit-HasComments: Yes
