ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: KUDU-2605: replace nvml with memkind ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/13188/14/src/kudu/util/cache-test.cc File src/kudu/util/cache-test.cc: http://gerrit.cloudera.org:8080/#/c/13188/14/src/kudu/util/cache-test.cc@498 PS14, Line 498: : CacheBaseTest(16 * 1024 * 1024) { > Why was the cache size changed from 14M to 16M? This relate to nvm_cache.cc Line 640. 14M is the minimum size required by nvml to initialize while 16M is for memkind. http://gerrit.cloudera.org:8080/#/c/13188/14/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/13188/14/src/kudu/util/nvm_cache.cc@612 PS14, Line 612: > Are you sure this change makes sense? The base of the allocation is ph.get( Fix. revert it to buf. I was doing some another code change. But there's no need to change here. http://gerrit.cloudera.org:8080/#/c/13188/14/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/13188/14/thirdparty/build-definitions.sh@801 PS14, Line 801: LDFLAGS="$EXTRA_LDFLAGS -L$PREFIX/lib -Wl,-rpath=$PREFIX/lib" \ > Does this also need -Wl,-rpath=$PREFIX/lib? Fix. Thanks for your review. -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 15 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Sat, 25 May 2019 12:57:58 +0000 Gerrit-HasComments: Yes
