ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/13188/9/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13188/9/CMakeLists.txt@1165 PS9, Line 1165: endif() > Why don't we need this anymore? Is it because we expressed the memkind->num Yes, it's only a dependency of memkind. No need add it to KUDU_BASE_LIBS -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 12 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2019 05:35:14 +0000 Gerrit-HasComments: Yes
