Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 12: (2 comments) > > Build Failed > > > > http://jenkins.kudu.apache.org/job/kudu-gerrit/17613/ : FAILURE > > Looks like there still will be one unit test failure. Is this also not > related to this patch? It's not related, you can ignore it. http://gerrit.cloudera.org:8080/#/c/13188/9/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13188/9/CMakeLists.txt@1165 PS9, Line 1165: endif() Why don't we need this anymore? Is it because we expressed the memkind->numa dependency on L1150? http://gerrit.cloudera.org:8080/#/c/13188/12/src/kudu/client/symbols.map File src/kudu/client/symbols.map: http://gerrit.cloudera.org:8080/#/c/13188/12/src/kudu/client/symbols.map@53 PS12, Line 53: # jemalloc : operator*; This means that we can potentially ship a Kudu client library with an embedded malloc implementation. We have client APIs that allocate memory from inside the client library, then hand it over to the application to use and deallocate (and vice versa). If there are two malloc implementations at play (one in the library and one in the application), allocation in one and deallocation in the other could lead to memory corruption. The older nvml library also bundled jemalloc, and this wasn't an issue then. Why is it an issue with memkind? What are we doing differently? -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 12 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2019 05:30:38 +0000 Gerrit-HasComments: Yes
