helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 )
Change subject: [tablet] Support accurate count of rows ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/13456/10/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: http://gerrit.cloudera.org:8080/#/c/13456/10/src/kudu/tablet/compaction-test.cc@1206 PS10, Line 1206: ASSERT_NO_FATAL_FAILURE(); > Since you've wrapped function calls that can ASSERT with NO_FATALS(), you d Done http://gerrit.cloudera.org:8080/#/c/13456/10/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: http://gerrit.cloudera.org:8080/#/c/13456/10/src/kudu/tablet/diskrowset.cc@205 PS10, Line 205: if (rowset_metadata_->tablet_metadata()->supports_live_row_count() && > After reviewing this a couple times, I think it'd be clearer if IncrementLi Yea, very good advice! -- To view, visit http://gerrit.cloudera.org:8080/13456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e6378e289bb85024c29e96c2b153fc417ed6412 Gerrit-Change-Number: 13456 Gerrit-PatchSet: 10 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Tue, 04 Jun 2019 05:50:33 +0000 Gerrit-HasComments: Yes
