Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 )
Change subject: [tablet] Support accurate count of rows ...................................................................... Patch Set 13: Code-Review+1 (2 comments) One last nit and this looks good to go! http://gerrit.cloudera.org:8080/#/c/13456/13/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/13456/13/src/kudu/tablet/tablet.cc@1922 PS13, Line 1922: *count += tmp; nit: can remove this. http://gerrit.cloudera.org:8080/#/c/13456/11/src/kudu/tserver/tablet_copy_client-test.cc File src/kudu/tserver/tablet_copy_client-test.cc: http://gerrit.cloudera.org:8080/#/c/13456/11/src/kudu/tserver/tablet_copy_client-test.cc@412 PS11, Line 412: } : : TEST_F(TabletCopyClientTest, TestSupportsLiveRowCount) { : ASSERT_OK(StartCopy()); : > No, seems impossible. The 'BootstrapTablet' doesn't help. Maybe L786~L806 i OK. We should make sure that we have some test coverage for the correctness of the live row count after tablet copying, though this can be in a follow-up patch when the row count is more externally available (e.g. from an RPC). -- To view, visit http://gerrit.cloudera.org:8080/13456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e6378e289bb85024c29e96c2b153fc417ed6412 Gerrit-Change-Number: 13456 Gerrit-PatchSet: 13 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Wed, 05 Jun 2019 16:42:29 +0000 Gerrit-HasComments: Yes
