Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13534 )
Change subject: KUDU-2809 (2/6): skip unobservable rows when iterating an MRS ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13534/2/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/13534/2/src/kudu/tablet/memrowset.h@586 PS2, Line 586: row : // row > nit: s/row row/row/ Done http://gerrit.cloudera.org:8080/#/c/13534/2/src/kudu/tablet/memrowset.h@593 PS2, Line 593: bool insert_excluded, > nit: maybe doc this param I did; see L569-L570. It's a quirky style (bunching up the enum definition with the function) but I like that it "scopes" the enum to just this one usage. -- To view, visit http://gerrit.cloudera.org:8080/13534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I801991260749d1f810540cb32ec84c3ea6a02160 Gerrit-Change-Number: 13534 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 07 Jun 2019 05:52:04 +0000 Gerrit-HasComments: Yes
