Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13534 )
Change subject: KUDU-2809 (2/6): skip unobservable rows when iterating an MRS ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13534/2/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/13534/2/src/kudu/tablet/memrowset.h@593 PS2, Line 593: bool insert_excluded, > But insert_excluded _is_ documented. Here's the full block comment: Thanks for pointing that out. It must have been too late to be reviewing bit patches when I finished up last night. I don't love the function comment above the enum but NBD. -- To view, visit http://gerrit.cloudera.org:8080/13534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I801991260749d1f810540cb32ec84c3ea6a02160 Gerrit-Change-Number: 13534 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2019 18:47:00 +0000 Gerrit-HasComments: Yes
