Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13534 )
Change subject: KUDU-2809 (2/6): skip unobservable rows when iterating an MRS ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13534/2/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/13534/2/src/kudu/tablet/memrowset.h@593 PS2, Line 593: bool insert_excluded, > I did; see L569-L570. I should have highlighted it; I was talking about insert_excluded not apply_status, which lgtm, but I wouldn't say it's a blocker since looking at the impl makes it clear -- To view, visit http://gerrit.cloudera.org:8080/13534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I801991260749d1f810540cb32ec84c3ea6a02160 Gerrit-Change-Number: 13534 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2019 07:06:54 +0000 Gerrit-HasComments: Yes
