Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14516 )
Change subject: util: fix macOS build of thread.cc ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14516/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/14516/1/src/kudu/util/thread.cc@a430 PS1, Line 430: We do have multiple places in the code that use size_t, why doesn't mac build fail because of those? -- To view, visit http://gerrit.cloudera.org:8080/14516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb61d9a933a9b76ec73fbfd0a4ef555bc27786d Gerrit-Change-Number: 14516 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 20 Oct 2019 21:44:36 +0000 Gerrit-HasComments: Yes
