Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14516 )
Change subject: util: fix macOS build of thread.cc ...................................................................... Patch Set 2: > Patch Set 2: > > This came up last in commit 5c776b0fa. I thought the solution there made more > sense: explicitly cast the size_t into a uint64_t before passing to EasyJson > rather. Implicitly casting the result of unordered_map::size() from size_t > into uint64_t seems worse to me because what's going on is less obvious. Ack; I don't think I'll switch approaches unless you feel strongly about it. I don't think this approach is that much less obvious. -- To view, visit http://gerrit.cloudera.org:8080/14516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb61d9a933a9b76ec73fbfd0a4ef555bc27786d Gerrit-Change-Number: 14516 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 21 Oct 2019 05:16:24 +0000 Gerrit-HasComments: No
