Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14516 )
Change subject: util: fix macOS build of thread.cc ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14516/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/14516/1/src/kudu/util/thread.cc@a430 PS1, Line 430: > It's not the fact that this map is size_t, but rather the assignment at L45 Yep, on MacOS uint64_t and size_t are different types. Try this on macOS and Linux: #include <cstdint> #include <iostream> #include <type_traits> using namespace std; int main() { cout << std::is_same<size_t, uint64_t>() << endl; return 0; } -- To view, visit http://gerrit.cloudera.org:8080/14516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb61d9a933a9b76ec73fbfd0a4ef555bc27786d Gerrit-Change-Number: 14516 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 21 Oct 2019 02:25:47 +0000 Gerrit-HasComments: Yes
