Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h File src/kudu/rpc/connection.h: http://gerrit.cloudera.org:8080/#/c/16444/1/src/kudu/rpc/connection.h@295 PS1, Line 295: 0x7fffffff Nit: It'd be better to use the numeric_limits instead of this constant for mask. static constexpr uint32_t mask = std::numeric_limits<int32_t>::max(); -- To view, visit http://gerrit.cloudera.org:8080/16444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53 Gerrit-Change-Number: 16444 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 12 Sep 2020 23:58:53 +0000 Gerrit-HasComments: Yes
