Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16444 )
Change subject: [rpc] simplify Connection::GetNextCallId() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h File src/kudu/rpc/connection.h: http://gerrit.cloudera.org:8080/#/c/16444/2/src/kudu/rpc/connection.h@296 PS2, Line 296: ++next_call_id_ Before this change, the returned values for GetNextCallId() would start from 1 and now it would start from 2, considering next_call_id_ is initialized with 1. Moreover meaning of next_call_id_ is changed and should be named curr_call_id_ instead and it should start from 0 instead to keep the return values functionally same as before this change, no? -- To view, visit http://gerrit.cloudera.org:8080/16444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53 Gerrit-Change-Number: 16444 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Sep 2020 01:19:24 +0000 Gerrit-HasComments: Yes
