Hello Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16444 to look at the new patch set (#2). Change subject: [rpc] simplify Connection::GetNextCallId() ...................................................................... [rpc] simplify Connection::GetNextCallId() This changelist simplifies the code to compute next call identifier. Synthetic performance results look good, no performance degradation is observed. Before: Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs): 9264.974859 task-clock # 9.045 CPUs utilized ( +- 0.69% ) 87,544 context-switches # 0.009 M/sec ( +- 1.28% ) 1,452 cpu-migrations # 0.157 K/sec ( +- 20.67% ) 3,216 page-faults # 0.347 K/sec ( +- 1.05% ) 26,213,352,542 cycles # 2.829 GHz ( +- 0.73% ) 27,520,087,657 instructions # 1.05 insns per cycle ( +- 1.27% ) 4,375,784,153 branches # 472.293 M/sec ( +- 1.25% ) 22,713,237 branch-misses # 0.52% of all branches ( +- 1.20% ) 1.024363805 seconds time elapsed ( +- 0.05% ) After: Performance counter stats for './bin/rpc-bench --gtest_filter=*BenchmarkCallsAsync' (10 runs): 8744.870402 task-clock # 8.540 CPUs utilized ( +- 3.32% ) 86,214 context-switches # 0.010 M/sec ( +- 2.94% ) 1,518 cpu-migrations # 0.174 K/sec ( +- 22.82% ) 3,183 page-faults # 0.364 K/sec ( +- 1.19% ) 24,708,133,421 cycles # 2.825 GHz ( +- 3.36% ) 25,856,687,203 instructions # 1.05 insns per cycle ( +- 3.76% ) 4,111,319,492 branches # 470.141 M/sec ( +- 3.74% ) 21,390,733 branch-misses # 0.52% of all branches ( +- 3.66% ) 1.023946171 seconds time elapsed ( +- 0.05% ) Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53 --- M src/kudu/rpc/connection.h 1 file changed, 5 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/16444/2 -- To view, visit http://gerrit.cloudera.org:8080/16444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fefe8b4c41fdde6e9744f2efec9476af8269c53 Gerrit-Change-Number: 16444 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120)