Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16494 )
Change subject: KUDU-3192: [hms] Leverage the cluster ID in HMS sync ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16494/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16494/1//COMMIT_MSG@9 PS1, Line 9: This patch propagates the cluster ID to the HMS entries for Could you also add tests where we create some real-looking metadata with no or different cluster IDs and ensure we ignore or account for it as appropriate? http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/master/hms_notification_log_listener.cc@363 PS1, Line 363: before_table.tableName, cluster_id); Should dereference cluster_id http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/master/hms_notification_log_listener.cc@437 PS1, Line 437: // If there is not a cluster ID, for maximum compatibility we should assume this is an older Uncomment this? Also maybe encapsulate in some FilterDifferentClusterId() method? -- To view, visit http://gerrit.cloudera.org:8080/16494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I865b418a3cc4e11c889cc4757cd940831c43af17 Gerrit-Change-Number: 16494 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 23 Sep 2020 18:35:49 +0000 Gerrit-HasComments: Yes
