Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16494 )

Change subject: KUDU-3192: [hms] Leverage the cluster ID in HMS sync
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/hms/hms_catalog.h
File src/kudu/hms/hms_catalog.h:

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/hms/hms_catalog.h@66
PS1, Line 66:  // Creates a new table entry in the HMS.
            :   //
            :   // If 'owner' is omitted the table will be created without an 
owner. This is
            :   // useful in circumstances where the owner is not known, for 
example when
            :   // creating an HMS table entry for an existing Kudu table.
            :   //
            :   // Fails the HMS is unreachable, or a table with the same name 
is already present.
nit: update the comment with the cluster_id? The same for other similar methods.


http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/master/hms_notification_log_listener.cc
File src/kudu/master/hms_notification_log_listener.cc:

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/master/hms_notification_log_listener.cc@356
PS1, Line 356: This is safe because we still validate the table ID
             :   // which is universally unique
Does it mean the table ID will never be the same even in across different 
clusters?


http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:

http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/tools/tool_action_hms.cc@245
PS1, Line 245: row.resize
nit: samer here.


http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/tools/tool_action_hms.cc@256
PS1, Line 256: adjust row.resize below
nit: adjust 'row.resize' below.



--
To view, visit http://gerrit.cloudera.org:8080/16494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I865b418a3cc4e11c889cc4757cd940831c43af17
Gerrit-Change-Number: 16494
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 24 Sep 2020 22:11:20 +0000
Gerrit-HasComments: Yes

Reply via email to