Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16494 )
Change subject: KUDU-3192: [hms] Leverage the cluster ID in HMS sync ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16494/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16494/4/src/kudu/master/catalog_manager.cc@5511 PS4, Line 5511: : const string& CatalogManager::cluster_id() const { : return master_->cluster_id(); : } Looking around for how this can be thread-safe, I think the answer is that this is only mutated and accessed while the leader lock is held. If so, can you add a comment mentioning that? And maybe assert that a lock is held? -- To view, visit http://gerrit.cloudera.org:8080/16494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I865b418a3cc4e11c889cc4757cd940831c43af17 Gerrit-Change-Number: 16494 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 30 Sep 2020 18:58:08 +0000 Gerrit-HasComments: Yes
