Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13004 )
Change subject: [build] Fix the java compatibility checker script ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13004/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13004/1//COMMIT_MSG@13 PS1, Line 13: > Nit: extra space here. Done http://gerrit.cloudera.org:8080/#/c/13004/1/build-support/check_compatibility.py File build-support/check_compatibility.py: http://gerrit.cloudera.org:8080/#/c/13004/1/build-support/check_compatibility.py@204 PS1, Line 204: # Run the build in each tree. > Hmm, would be nice if this would work on existing build output, since it'll I agree that would be a good enhancement for follow on changes. For now, given the gradle build has been around a while, this is better than nothing and can be use for releases and arbitrary commits. -- To view, visit http://gerrit.cloudera.org:8080/13004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Lieber-Dembo <a...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 07 Jan 2021 21:20:53 +0000 Gerrit-HasComments: Yes
