Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/13004 )
Change subject: [build] Fix the java compatibility checker script ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py File build-support/check_compatibility.py: http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@121 PS3, Line 121: def find_client_jars(path): > I exclude jars because they are know to be non-public or application jars w Done http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@175 PS3, Line 175: if src_name == dst_name: > Currently the script uses super rudimentary arguments. I will enhance the a Done -- To view, visit http://gerrit.cloudera.org:8080/13004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Jan 2021 18:28:37 +0000 Gerrit-HasComments: Yes
