Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13004 )
Change subject: [build] Fix the java compatibility checker script ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/13004/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13004/3//COMMIT_MSG@22 PS3, Line 22: incorparate > incorporate ? Done http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py File build-support/check_compatibility.py: http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@109 PS3, Line 109: if os.path.exists(get_japicmp_path()): : logging.info("japicmp is already downloaded.") > Will it work as expected when a new version of the tool is available? Mayb Done http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@115 PS3, Line 115: "curl", "-o" > nit: does it make sense to add few options to match the behavior of downloa Done http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@121 PS3, Line 121: return [j for j in all_jars if ( > Nit: if I am reading this correctly, this code is excluding 9 patterns in o I exclude jars because they are know to be non-public or application jars which do not have public API. I prefer a exclusion to explicit inclusion so that by default we scan and check APIs if a new jar is added. http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@175 PS3, Line 175: # TODO(ghenke): Add support for --error-on-binary-incompatibility and --error-on-source-incompatibility. > Currently, the script produces a lot of output for modified and added metho Currently the script uses super rudimentary arguments. I will enhance the arguments in a follow on patch once I understand what types of options a scheduled job might need. -- To view, visit http://gerrit.cloudera.org:8080/13004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3 Gerrit-Change-Number: 13004 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Jan 2021 17:13:04 +0000 Gerrit-HasComments: Yes
