Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke,
Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17141
to look at the new patch set (#5).
Change subject: KUDU-3226 Validate List of Masters for the tool kudu cluster
ksck
......................................................................
KUDU-3226 Validate List of Masters for the tool kudu cluster ksck
This patch checks for duplicate kudu masters provided in kudu cluster
ksck/rebalance commands. It only does a string comparison check to
detect and report all the duplicate master(/s). If a user provides the
IP address and hostname of the same master, it won't be able to catch
the duplicates. That seems more of a deliberate attempt rather than a
common mistake a user could make and hence not considering that case.
Also wrote a simple test case to test this functionality. Decided not
to spin up a test cluster for this as this is more of client side check
and a master is not actually contacted.
This change got conflicted with another test i.e.
AdminCliTest.TestAuthzResetCacheIncorrectMasterAddressList. Updated this
test as well to by creating a new external mini cluster with three
masters and running the command in the test with just one master
Change-Id: I2f3b2b7dcf2ac78cb95cf43242651e3ce8fddf6f
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
3 files changed, 41 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/17141/5
--
To view, visit http://gerrit.cloudera.org:8080/17141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f3b2b7dcf2ac78cb95cf43242651e3ce8fddf6f
Gerrit-Change-Number: 17141
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
