Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17141 )
Change subject: KUDU-3226 Validate List of Masters for the tool kudu cluster ksck ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17141/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17141/2//COMMIT_MSG@9 PS2, Line 9: kudu cluster : ksck/rebalance > That is correct. But I manually tried all the commands which have masters t I stand corrected. I tested with the new binary and here are all the modes which are affected (detect duplicate master addresses and report) by this change : kudu cluster kudu perf kudu table kudu master kudu tablet kudu server The existing binary only kudu cluster mode reports an issue with duplicate master addresses which is because the rebalancer calls ksck internally[1] and ksck constructs a map of kudu masters' UUIDs and finds duplicates [2] and dies. Rest of the modes do not construct a map of the master UUIDs and hence do not die. [1] https://github.com/apache/kudu/blob/master/src/kudu/tools/rebalancer_tool.cc#L626-L635 [2] https://github.com/apache/kudu/blob/master/src/kudu/tools/ksck.cc#L339-L344 -- To view, visit http://gerrit.cloudera.org:8080/17141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f3b2b7dcf2ac78cb95cf43242651e3ce8fddf6f Gerrit-Change-Number: 17141 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Mar 2021 04:13:24 +0000 Gerrit-HasComments: Yes
