Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17141 )
Change subject: [tool] KUDU-3226 Validate List of Masters kudu ksck ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Please wait for more comments from Andrew, Alexey. http://gerrit.cloudera.org:8080/#/c/17141/7/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/17141/7/src/kudu/tools/tool_action_common.cc@665 PS7, Line 665: " " Nit: delimiting by a comma will be preferred. http://gerrit.cloudera.org:8080/#/c/17141/7/src/kudu/tools/tool_action_common.cc@665 PS7, Line 665: string duplicate_masters_str = JoinStrings(duplicate_masters, " "); : return Status::InvalidArgument("Duplicate master addresses specified: " + duplicate_masters_str); Nit: Get rid of the local variable and directly use in InvalidArgument() call. -- To view, visit http://gerrit.cloudera.org:8080/17141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f3b2b7dcf2ac78cb95cf43242651e3ce8fddf6f Gerrit-Change-Number: 17141 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 11 Mar 2021 16:46:56 +0000 Gerrit-HasComments: Yes
