Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18604 )
Change subject: [Tools] Support to config hash bucket numbers when copy a table ...................................................................... Patch Set 9: (1 comment) > Patch Set 6: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/18604/6/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18604/6/src/kudu/tools/table_scanner.cc@450 PS6, Line 450: for (int i = 0; i < hash_bucket_nums_str.size(); i++) { : int bucket_num = 0; : bool is_number = safe_strto32(hash_bucket_nums_str[i], &bucket_num); : if (!is_number) { : return Status::InvalidArgument("Hash bucket number must be digit!"); : } : if (bucket_num < 2) { : return Status::InvalidArgument("Hash bucket number must be >= 2!"); : } : > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/18604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cec38e5ea09c66bfed20622b85033602da60d41 Gerrit-Change-Number: 18604 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 29 Jun 2022 12:13:20 +0000 Gerrit-HasComments: Yes
