Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18604 )
Change subject: [Tools] Support to config hash bucket numbers when copy a table ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18604/6/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18604/6/src/kudu/tools/table_scanner.cc@450 PS6, Line 450: } : } : } : int i = 0; : for (const auto& hash_dimension : partition_schema.hash_schema()) { : int num_buckets = hash_bucket_nums[i] != -1 ? hash_bucket_nums[i] : : hash_dimension.num_buckets; : auto hash_columns = convert_column_ids_to_names(hash_dimension.column_ids); : table_creator->add_hash_partitions(hash_columns, : > The size of vector<int> hash_bucket_nums will exactly be equal to the size Would it better to specify all the hash dimensions? The number of hash dimensions would not be too large in the real world, may be 5 hash dimensions is large enough. Ignore redundant numbers or add default -1 may introduce mistaken errors. -- To view, visit http://gerrit.cloudera.org:8080/18604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cec38e5ea09c66bfed20622b85033602da60d41 Gerrit-Change-Number: 18604 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 29 Jun 2022 02:49:10 +0000 Gerrit-HasComments: Yes
