Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18604 )
Change subject: [Tools] Support to config hash bucket numbers when copy a table ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18604/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18604/5//COMMIT_MSG@9 PS5, Line 9: cluster nit: should be 'table', we can copy table to the same cluster. http://gerrit.cloudera.org:8080/#/c/18604/5//COMMIT_MSG@9 PS5, Line 9: the same table : in the destination cluster nit: the table with the same schema. http://gerrit.cloudera.org:8080/#/c/18604/5/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18604/5/src/kudu/tools/table_scanner.cc@443 PS5, Line 443: if (!is_number) nit: better to add brackets even if there is only one line. -- To view, visit http://gerrit.cloudera.org:8080/18604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cec38e5ea09c66bfed20622b85033602da60d41 Gerrit-Change-Number: 18604 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 24 Jun 2022 10:31:54 +0000 Gerrit-HasComments: Yes
