Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19411 )
Change subject: [tools] add --tables flag to 'local_replica delete' ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/kudu-tool-test.cc@4329 PS3, Line 4329: } nit: Also check the left replica's table name is not kTableName? http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19411/3/src/kudu/tools/tool_action_local_replica.cc@801 PS3, Line 801: if (uniq_count > tablets_to_delete.size()) { Because the input is pattern now, one pattern may match multiple tablet ids, and some pattern may match none tablet id, so even if uniq_count <= tablets_to_delete.size(), there maybe some patterns are ignored. right? -- To view, visit http://gerrit.cloudera.org:8080/19411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329 Gerrit-Change-Number: 19411 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Thu, 12 Jan 2023 13:11:54 +0000 Gerrit-HasComments: Yes
