Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19411 )
Change subject: [tools] add --tables flag to 'local_replica delete' ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/19411/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19411/5//COMMIT_MSG@16 PS5, Line 16: can not Do you mean "cannot" ? http://gerrit.cloudera.org:8080/#/c/19411/5//COMMIT_MSG@16 PS5, Line 16: support nit: supports http://gerrit.cloudera.org:8080/#/c/19411/5//COMMIT_MSG@17 PS5, Line 17: whether there is an illegal tablet id pattern well and truly, unless : all the specified tablet id patterns are tablet ids. : Do you mean tablet id patterns will be treated as invalid? http://gerrit.cloudera.org:8080/#/c/19411/5/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19411/5/src/kudu/tools/kudu-tool-test.cc@4320 PS5, Line 4320: --tables=$1 If multiple tables can be entered by user, could you add another test case to cover multiple tables (e.g. 2 tables)? http://gerrit.cloudera.org:8080/#/c/19411/5/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19411/5/src/kudu/tools/tool_action_local_replica.cc@793 PS5, Line 793: GetTabletIdsByTableName nit: It would worth finding out how this performs on scaled configuration with thousands of tablets. -- To view, visit http://gerrit.cloudera.org:8080/19411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329 Gerrit-Change-Number: 19411 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Mon, 16 Jan 2023 15:13:09 +0000 Gerrit-HasComments: Yes
