Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19411 )
Change subject: [tools] add --tables flag to 'local_replica delete' ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/19411/5/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19411/5/src/kudu/tools/tool_action_local_replica.cc@793 PS5, Line 793: GetTabletIdsByTableName > nit: It would worth finding out how this performs on scaled configuration w I think there shouldn't be too much overhead in FsManager::ListTabletIds and TabletMetadata::Load since we already open the tablet server's metadata at L790. -- To view, visit http://gerrit.cloudera.org:8080/19411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329 Gerrit-Change-Number: 19411 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Tue, 17 Jan 2023 06:49:40 +0000 Gerrit-HasComments: Yes