Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19411 )
Change subject: [tools] add --tables flag to 'local_replica delete' ...................................................................... Patch Set 7: Code-Review+2 (4 comments) Overall looks good to me, just a few nits in comments and the commit message. Thank you for the contribution! http://gerrit.cloudera.org:8080/#/c/19411/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19411/7//COMMIT_MSG@9 PS7, Line 9: deletion nit: either 'deleting' or 'deletion of' http://gerrit.cloudera.org:8080/#/c/19411/7//COMMIT_MSG@14 PS7, Line 14: delete nit: deleting http://gerrit.cloudera.org:8080/#/c/19411/7//COMMIT_MSG@20 PS7, Line 20: is was http://gerrit.cloudera.org:8080/#/c/19411/7/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19411/7/src/kudu/tools/tool_action_local_replica.cc@234 PS7, Line 234: pattern nit: patterns -- To view, visit http://gerrit.cloudera.org:8080/19411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d862a715f05179b2e8def0d1cdfe58c32299329 Gerrit-Change-Number: 19411 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Sat, 21 Jan 2023 05:03:43 +0000 Gerrit-HasComments: Yes
