Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19585 )
Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset ...................................................................... Patch Set 3: > Patch Set 3: > > (1 comment) Thanks for your explanation. I reviewed the origin patch: https://gerrit.cloudera.org/c/17636/. If the flow of 'a master joins' is correct before this patch(17636), the behavior is no changes. It seems no problem. And it seems running well for a long time. I simply review 'master_auto_join_cluster'. I think 'kudu master' may rare execute the codes you refer to. Because masters' raft member change is maintenance by administrators. For example, currently there is a kudu cluster, masters: A, B, C and I want to join D. I am the administrator, My ops(simply): 1) I change master_addresses from A,B,C to A,B,C,D (of course, I should rewrite the raft config, Add D to them) 2) I restart A, B, C 3) I start D So, 'needs_add' is False. D does not run the followings: ' // If we succeeded, wipe the system catalog on this node and initiate a // copy from another node. RETURN_NOT_OK(ClearLocalSystemCatalogAndCopy(leader_hp)); server.reset(new Master(opts)); RETURN_NOT_OK(server->Init()); RETURN_NOT_OK(server->Start()); ' I guess what you said happens reason is the operation order. Maybe your ops: 1) Start D with raft config A,B,C,D and masters_address A,B,C,D and D failed. Am I right? What's your ops? -- To view, visit http://gerrit.cloudera.org:8080/19585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc32d7ab02201382debcbe36311579550353bf71 Gerrit-Change-Number: 19585 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Mar 2023 08:50:08 +0000 Gerrit-HasComments: No
