Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19585 )
Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset ...................................................................... Patch Set 3: (1 comment) > > Patch Set 3: > > > > (1 comment) > > I got it. Thanks. Maybe you can destroy the singleton BlockCache > before initiating the master at the second time, just like: > ClearLocalSystemCatalogAndCopy(leader_hp). Destroying a singleton may not be a good idea. util::gtl::Singleton is used and documentation states: "// (a) The instance is normally never destroyed. Destroying a Singleton is // complex and error-prone; C++ books go on about this at great length, // and I have seen no perfect general solution to the problem. // We *do* offer UnsafeReset() which is not thread-safe at all. " http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG@9 PS3, Line 9: empty local directories > Thanks for your explanation. I reviewed the origin patch: https://gerrit.cl You are correct, A,B,C are not restarted. You can see the exact commands in the jira issue: https://issues.apache.org/jira/browse/KUDU-3437 But the point is in my opinion: even if A,B,C were started without D, if D is added properly, then A,B,C don't have to be restarted. An other easier solution to make 'needs_add' false is just to start D again. Second time, it is already added and starts properly. But I still think this is just a workaround and this patch is a better solution. -- To view, visit http://gerrit.cloudera.org:8080/19585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc32d7ab02201382debcbe36311579550353bf71 Gerrit-Change-Number: 19585 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Mar 2023 11:07:13 +0000 Gerrit-HasComments: Yes
