Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19585 )
Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Thank you for the fix! http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19585/3//COMMIT_MSG@9 PS3, Line 9: empty local directories > Ok, My advice is don't change the default value. I am afraid that it may ca I'd vote for updating the default value for block_cache_metrics_policy in MasterOptions, and just override the setting for kudu-master started as a part of mini-cluster -- that way it's cleaner since running all Kudu components just in one process is rather an exception that's added for test purposes. With that, having the code as in current PS4 looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/19585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc32d7ab02201382debcbe36311579550353bf71 Gerrit-Change-Number: 19585 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Wed, 29 Mar 2023 23:32:10 +0000 Gerrit-HasComments: Yes
