Yuqi Du has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19501 )

Change subject: [Tool] Show the information of a tablet
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9
PS12, Line 9: This tool is used to show the table name, table id and all
            : replicas on different tablet servers according to the tablet
            : id.
> This commit is done as you advised. I maybe miss something. Could you give
I am thinking the implement scheme of this patch again.

rpc GetTabletLocations(GetTabletLocationsRequestPB) returns 
(GetTabletLocationsResponsePB)
You can use this rpc in Kudu CLI to implements this patch. The information of 
tablet name is not
in GetTabletLocationsResponsePB, so the message structure 
GetTabletLocationsResponsePB can add this field, like this:

message GetTabletLocationsResponsePB {
  optional MasterErrorPB error = 1;

  repeated TabletLocationsPB tablet_locations = 2;

  // Used if 'intern_ts_infos_in_response' was requested.
  // See InternedReplicaPB above.
  repeated TSInfoPB ts_infos = 4;

  message Error {
    required bytes tablet_id = 1;
    required AppStatusPB status = 2;
  }
  repeated Error errors = 3;

  // add two fields at this.
  optional string table_id = 5;
  optional string table_name = 6;
}

All information of your output is included can extract from this response.
It's not necessary to change client's codes, as some people said, public some 
information about tablet is not good.


http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto
File src/kudu/master/master.proto:

http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto@503
PS12, Line 503: table_info_in_response
> table_info is stored in TabletLocationsPB of GetTabletLocationsResponsePB.
Done



--
To view, visit http://gerrit.cloudera.org:8080/19501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe
Gerrit-Change-Number: 19501
Gerrit-PatchSet: 13
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: KeDeng <kdeng...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:23:51 +0000
Gerrit-HasComments: Yes

Reply via email to