Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9 PS12, Line 9: This tool is used to show the table name, table id and all : replicas on different tablet servers according to the tablet : id. I review this patch again. I find GetTabletLocationsRequestPB and GetTabletLocationsResponsePB can get most of the information. The missing infomation is table name. So I think we can add this information field about table in GetTabletLocationsResponsePB. At CLI command side, send GetTabletLocations request like what some other command does, we can avoid changing kudu cpp client and avoid publishing some messages we don't want to publish. What do you think? http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto@503 PS12, Line 503: table_info_in_response It seems 'GetTabletLocationsResponsePB' has no such field to save 'table_info', how to use table_info_in_response? -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 11:23:16 +0000 Gerrit-HasComments: Yes
