Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 )
Change subject: [Tool] Show the information of a tablet ...................................................................... Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@9 PS12, Line 9: This tool is used to show the table name, table id and all : replicas on different tablet servers according to the tablet : id. > I review this patch again. This commit is done as you advised. I maybe miss something. Could you give more explain in detail? http://gerrit.cloudera.org:8080/#/c/19501/12//COMMIT_MSG@17 PS12, Line 17: This tool will be helpful for debuging. The following is an : exmple: : : Table id: 9112ec4b6eac48f5967da5a1f20610b0, Table name: test_table : Tablet Server UUID | Host | Port | Is Leader : ----------------------------------+-----------------+-------+----------- : 4cd055e0cf3b4165823747e3c349dc6f | 127.241.215.131 | 45963 | true : 65a671158cd74ac3995f5c68180621b8 | 127.241.215.130 | 42211 | false : 6b6ef15e7d4a471f92f4c1eca1a46638 | 127.241.215.129 | 36321 | false > How about add examples of command lines?This will give us a more direct und Done http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/catalog_manager.h@802 PS11, Line 802: // Replace the given tablet with a new, empty one. The replaced tablet is > Done Done http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19501/11/src/kudu/master/master.proto@459 PS11, Line 459: optional ListTablesResponsePB.TableInfo table_info = 8; > I meant if reuse ListTablesRequestPB to collect table info (not add an extr Do you mean the client send 2 RPCs to get related information? GetTabletLocationsRequestPB RPC gets tablet location information, and ListTablesRequestPB RPC gets the table information? But we don't know the table name when finished GetTabletLocationsRequestPB RPC. How to send ListTablesRequestPB RPC. http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/19501/12/src/kudu/master/master.proto@503 PS12, Line 503: table_info_in_response > It seems 'GetTabletLocationsResponsePB' has no such field to save 'table_in table_info is stored in TabletLocationsPB of GetTabletLocationsResponsePB. Please see line 459. -- To view, visit http://gerrit.cloudera.org:8080/19501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ae5f61f50a44c4787843df76adaa61700ae9fe Gerrit-Change-Number: 19501 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Thu, 06 Apr 2023 14:32:26 +0000 Gerrit-HasComments: Yes
