KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 )
Change subject: KUDU-3413 [multi-tenancy] add tenant info in metadata for multi-tenancy ...................................................................... Patch Set 16: (3 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/19622/15/src/kudu/server/server_base_options.h File src/kudu/server/server_base_options.h: http://gerrit.cloudera.org:8080/#/c/19622/15/src/kudu/server/server_base_options.h@67 PS15, Line 67: > Only used in tests ? Add some comments if it's true. Not like this. Except for unit tests, this structure can be used in the new cluster to initialize the default tenant key, corresponding to the existing server key. http://gerrit.cloudera.org:8080/#/c/19622/15/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: http://gerrit.cloudera.org:8080/#/c/19622/15/src/kudu/tools/tool_action_fs.cc@125 PS15, Line 125: LOG(ERROR) << "'tenant_name', 'tenant_id', 'tenant_key', 'tenant_key_iv', and " > nit: add spaces Done http://gerrit.cloudera.org:8080/#/c/19622/15/src/kudu/tools/tool_action_fs.cc@294 PS15, Line 294: !FLAGS_tenant_name.empty()) { : tenant_name = FLAGS_tenant_name; : tenant_id = FLAGS_tenant_id; : encryption_key = FLAGS_tenant_key; : encryption_key_iv = FLAGS_tenant_key_i > They have been validated by GROUP_FLAG_VALIDATOR, here just check FLAGS_ten Done -- To view, visit http://gerrit.cloudera.org:8080/19622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e450d73940eb1dbaac6f905a46d6ccd084f15cf Gerrit-Change-Number: 19622 Gerrit-PatchSet: 16 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 11:43:42 +0000 Gerrit-HasComments: Yes
