Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 )
Change subject: KUDU-3413 [multi-tenancy] add tenant info in metadata for multi-tenancy ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/19622/2//COMMIT_MSG Commit Message: PS2: The body of the commit message should be reflowed to 72 characters. http://gerrit.cloudera.org:8080/#/c/19622/2//COMMIT_MSG@7 PS2, Line 7: [multi-tenancy] add tenant info > Done This makes the subject line pretty long. I don't think the tag is necessary as the JIRA is included as well. http://gerrit.cloudera.org:8080/#/c/19622/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19622/3//COMMIT_MSG@7 PS3, Line 7: KUDU-3413 [multi-tenancy] add tenant info in metadata for multi-tenancy nit: no need for the [tag] if it includes a JIRA. It would also help keeping the subject line shorter. The body of the message, however, can be reflowed to 72 characters. http://gerrit.cloudera.org:8080/#/c/19622/3/src/kudu/fs/fs.proto File src/kudu/fs/fs.proto: http://gerrit.cloudera.org:8080/#/c/19622/3/src/kudu/fs/fs.proto@54 PS3, Line 54: // configuration values. Based on the design doc, I assumed each tenant would have its own set of directories, so the instance file would only contain the tenant key/server key for a single tenant. What is the purpose of this? How does the fs manager know which tenant key to load? -- To view, visit http://gerrit.cloudera.org:8080/19622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e450d73940eb1dbaac6f905a46d6ccd084f15cf Gerrit-Change-Number: 19622 Gerrit-PatchSet: 16 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Mon, 12 Jun 2023 17:43:21 +0000 Gerrit-HasComments: Yes
