KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 )
Change subject: KUDU-3413 add tenant info in metadata for multi-tenancy ...................................................................... Patch Set 17: (4 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/19622/2//COMMIT_MSG Commit Message: PS2: > The body of the commit message should be reflowed to 72 characters. Done http://gerrit.cloudera.org:8080/#/c/19622/2//COMMIT_MSG@7 PS2, Line 7: add tenant info in metadata for > This makes the subject line pretty long. I don't think the tag is necessary Done http://gerrit.cloudera.org:8080/#/c/19622/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19622/3//COMMIT_MSG@7 PS3, Line 7: KUDU-3413 add tenant info in metadata for multi-tenancy > nit: no need for the [tag] if it includes a JIRA. It would also help keepin Done http://gerrit.cloudera.org:8080/#/c/19622/3/src/kudu/fs/fs.proto File src/kudu/fs/fs.proto: http://gerrit.cloudera.org:8080/#/c/19622/3/src/kudu/fs/fs.proto@54 PS3, Line 54: // configuration values. > Based on the design doc, I assumed each tenant would have its own set of di Yes, different tenants will have their own set of directories. To facilitate tenant management, in the implementation, all tenant information will be saved under the default tenant. This way, during the loading process, env can be instantiated separately and different directory sets can be managed according to the tenant information in the metadata. -- To view, visit http://gerrit.cloudera.org:8080/19622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e450d73940eb1dbaac6f905a46d6ccd084f15cf Gerrit-Change-Number: 19622 Gerrit-PatchSet: 17 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 13 Jun 2023 07:37:12 +0000 Gerrit-HasComments: Yes
