Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20084 )

Change subject: KUDU-1945 Backup/restore for tables with auto incrementing 
columns
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20084/2/java/kudu-backup-common/src/main/protobuf/backup.proto
File java/kudu-backup-common/src/main/protobuf/backup.proto:

http://gerrit.cloudera.org:8080/#/c/20084/2/java/kudu-backup-common/src/main/protobuf/backup.proto@52
PS2, Line 52:   bool is_auto_incrementing = 11;
BTW, what happens when a backup of a table with auto-incrementing column is 
used to restore the table when using backup tool of prior revision?  Is 
everything works as expected in terms of:
  * data integrity (i.e. absence of corruption)
  * return code (or visible result when running the restore app) compared with 
what actually happened under the hood



--
To view, visit http://gerrit.cloudera.org:8080/20084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I929d54d22c1c938ee67fdda9f4c2bb68c028b4ec
Gerrit-Change-Number: 20084
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <greber...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 18:44:03 +0000
Gerrit-HasComments: Yes

Reply via email to