Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 )
Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20084/6/src/kudu/common/schema.cc File src/kudu/common/schema.cc: PS6: > The intention of having it here is to have it close to where it was discove All right, it seems that's a long separate story. Then I'm fine to keep this as-is in this patch -- addressing that long-standing piece of tech debt is out of this patch's scope, of course. http://gerrit.cloudera.org:8080/#/c/20084/6/src/kudu/common/schema.cc@314 PS6, Line 314: ColumnSchema.getStrippedColumnSchema() would trigger the exception : // otherwise ... ColumnSchema.getStrippedColumnSchema() in the Java client would throw an exception otherwise -- To view, visit http://gerrit.cloudera.org:8080/20084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I929d54d22c1c938ee67fdda9f4c2bb68c028b4ec Gerrit-Change-Number: 20084 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 22:53:03 +0000 Gerrit-HasComments: Yes
