Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 )
Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20084/2/java/kudu-backup-common/src/main/protobuf/backup.proto File java/kudu-backup-common/src/main/protobuf/backup.proto: http://gerrit.cloudera.org:8080/#/c/20084/2/java/kudu-backup-common/src/main/protobuf/backup.proto@52 PS2, Line 52: bool is_auto_incrementing = 11; > BTW, what happens when a backup of a table with auto-incrementing column is Without this change the backup of table cannot be taken as it as en exception is thrown from ColumnSchema.getStrippedColumnSchema() when generating the column schema. Even if a backup is taken using this change, and a restore is attempted from an older backup-restore jar, an error is thrown during in ColumnSchema.ColumnSchemaBuilder() as we have a column with the reserved name - "auto_incrementing_column". So there is no data corruption but the return message doesn't explicitly mention to use a newer version of the jar. Since it is all a part of the Kudu java client, probably we can document the error message? -- To view, visit http://gerrit.cloudera.org:8080/20084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I929d54d22c1c938ee67fdda9f4c2bb68c028b4ec Gerrit-Change-Number: 20084 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Comment-Date: Thu, 22 Jun 2023 00:57:55 +0000 Gerrit-HasComments: Yes
