Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 )
Change subject: Do not enter ALTERING state just for replication factor changed. ...................................................................... Patch Set 3: (2 comments) > Patch Set 2: > > (3 comments) Thanks for the review. I have added a test that fails without the fix. Actually without the fix, it will time out while altering since the state of table is altering forever. http://gerrit.cloudera.org:8080/#/c/20830/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20830/2//COMMIT_MSG@17 PS2, Line 17: num > number Done http://gerrit.cloudera.org:8080/#/c/20830/2//COMMIT_MSG@17 PS2, Line 17: d, the former : condition is also needed. So > how about: the applicability of the changes for existing replicas is alread Sorry, I am not sure. The words here are trying to say that we can not make the table enter ALTERING state without checking the existing tablets number. -- To view, visit http://gerrit.cloudera.org:8080/20830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d20da7c0dd5912790aaa46e9fff366b2973d7a4 Gerrit-Change-Number: 20830 Gerrit-PatchSet: 3 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Comment-Date: Thu, 28 Dec 2023 08:06:39 +0000 Gerrit-HasComments: Yes
