Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 )
Change subject: Do not enter ALTERING state just for replication factor changed. ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20830/6/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/20830/6/src/kudu/integration-tests/alter_table-test.cc@2661 PS6, Line 2661: cluster_->mini_tablet_server(i)->server()-> I think here we are interested what the system catalog (i.e. master) knows about the state of the table, not tablet servers. Why not to use itest::GetTableLocations() here? http://gerrit.cloudera.org:8080/#/c/20830/6/src/kudu/integration-tests/alter_table-test.cc@2665 PS6, Line 2665: style nit: wrong indent -- To view, visit http://gerrit.cloudera.org:8080/20830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d20da7c0dd5912790aaa46e9fff366b2973d7a4 Gerrit-Change-Number: 20830 Gerrit-PatchSet: 6 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Comment-Date: Wed, 03 Jan 2024 17:38:28 +0000 Gerrit-HasComments: Yes
